Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Issue 1235663002: [turbofan] Reduce Float64 comparison to Float32. (Closed)

Created:
5 years, 5 months ago by martyn.capewell
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce Float64 comparison to Float32. Reduce Float64 comparison to Float32 when both inputs are conversions from Float32. Committed: https://crrev.com/ad7f35c49aa94b2bc625fe59a5e9251ef2645889 Cr-Commit-Position: refs/heads/master@{#29586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
martyn.capewell
This currently brings a little performance on the Jetstream gcc-loops benchmark, and seems like a ...
5 years, 5 months ago (2015-07-10 16:52:00 UTC) #2
Benedikt Meurer
LGTM.
5 years, 5 months ago (2015-07-13 04:38:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235663002/1
5 years, 5 months ago (2015-07-13 04:39:10 UTC) #5
commit-bot: I haz the power
The author martyn.capewell@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-13 04:39:13 UTC) #6
commit-bot: I haz the power
The author martyn.capewell@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-13 05:00:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 05:23:46 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 05:24:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad7f35c49aa94b2bc625fe59a5e9251ef2645889
Cr-Commit-Position: refs/heads/master@{#29586}

Powered by Google App Engine
This is Rietveld 408576698