Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1235653004: Improved action animations in sprites (Closed)

Created:
5 years, 5 months ago by viktorl
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improved action animations in sprites Actions can only be added once Makes sure instant actions are run on Repeat and RepeatForever Adds ActionGroup which runs actions in parallell Adds support for animation curves and easing Makes it possible to animate sizes and rects Fixes issue with SpriteBox not being updated R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/10e650b606f1d22bebfaf70fed60ba491a03e9f9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -38 lines) Patch
M sky/sdk/example/game/lib/action.dart View 11 chunks +229 lines, -38 lines 0 comments Download
M sky/sdk/example/game/lib/sprite_box.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/game/lib/sprites.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
viktorl
5 years, 5 months ago (2015-07-10 19:05:55 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1235653004/diff/1/sky/sdk/example/game/lib/sprites.dart File sky/sdk/example/game/lib/sprites.dart (right): https://codereview.chromium.org/1235653004/diff/1/sky/sdk/example/game/lib/sprites.dart#newcode8 sky/sdk/example/game/lib/sprites.dart:8: import 'dart:math' as Math; nit: We've been using ...
5 years, 5 months ago (2015-07-10 19:13:52 UTC) #4
viktorl
Committed patchset #1 (id:1) manually as 10e650b606f1d22bebfaf70fed60ba491a03e9f9 (presubmit successful).
5 years, 5 months ago (2015-07-10 19:26:48 UTC) #5
viktorl
5 years, 5 months ago (2015-07-10 19:27:19 UTC) #6
Message was sent while issue was closed.
On 2015/07/10 at 19:13:52, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/1235653004/diff/1/sky/sdk/example/game/lib/sp...
> File sky/sdk/example/game/lib/sprites.dart (right):
> 
>
https://codereview.chromium.org/1235653004/diff/1/sky/sdk/example/game/lib/sp...
> sky/sdk/example/game/lib/sprites.dart:8: import 'dart:math' as Math;
> nit: We've been using the local name |math| rather than |Math| for this
library.
> 
>
https://codereview.chromium.org/1235653004/diff/1/sky/sdk/example/game/lib/sp...
> sky/sdk/example/game/lib/sprites.dart:11: import
'package:sky/animation/curves.dart';
> This should probably go below with the other package imports.

Fixed and landed

Powered by Google App Engine
This is Rietveld 408576698