Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1235653002: Remove incorrect DCHECK in ~BrowserCdmManager. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
Reviewers:
xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect DCHECK in ~BrowserCdmManager. https://codereview.chromium.org/1225083002 fixed the core issue but left an incorrect DCHECK in the code. It is not the case that only a single BrowserCdmManager per RPH ID may be alive at a time, only that a single one corresponds to a given live process. (A reference-counted type can never be assumed to have bounded lifetime for the same reason garbage-collected types can never be assumed to have bounded lifetime.) This fixes ChildProcessLauncherBrowserTest.ChildSpawnFail's flakiness on cast_shell_linux when use_openssl is switched. BUG=506188, 462040 Committed: https://crrev.com/7f59ee147777a9df9e5a83462c6a230ad060e81e Cr-Commit-Position: refs/heads/master@{#338312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
5 years, 5 months ago (2015-07-10 16:32:36 UTC) #2
xhwang
On 2015/07/10 16:32:36, David Benjamin wrote: Good catch. I missed this. Yes, now we are ...
5 years, 5 months ago (2015-07-10 17:04:11 UTC) #3
xhwang
lgtm
5 years, 5 months ago (2015-07-10 17:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235653002/1
5 years, 5 months ago (2015-07-10 17:04:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 17:22:09 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 17:23:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f59ee147777a9df9e5a83462c6a230ad060e81e
Cr-Commit-Position: refs/heads/master@{#338312}

Powered by Google App Engine
This is Rietveld 408576698