Issue 1235633004: DON'T USE THIS -- Providing some missing POSIX File syscalls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235633004: DON'T USE THIS -- Providing some missing POSIX File syscalls. (Closed)

Created:
5 years, 5 months ago by Sean Klein

Modified:
5 years, 4 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

More Reviews

Description

Providing some missing POSIX File syscalls. This is based off of Petr Hosek's work here: https://chromiumcodereview.appspot.com/24889002/ BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Windows alignment for time.h #

Patch Set 7 : Changed utimes interface internally to pointer passing #

Patch Set 8 : try this on windows #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : prefix #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Patch Set 21 : #

Patch Set 22 : #

Patch Set 23 : #

Patch Set 24 : #

Patch Set 25 : #

Patch Set 26 : #

Patch Set 27 : windows links hurt #

Patch Set 28 : #

Patch Set 29 : #

Patch Set 30 : #

Patch Set 31 : #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1006 lines, -74 lines)			Patch
M	src/shared/platform/linux/nacl_host_dir.c	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	src/shared/platform/nacl_host_desc.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	4 chunks	+17 lines, -4 lines	0 comments	Download
M	src/shared/platform/nacl_host_dir.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/shared/platform/osx/nacl_host_dir.c	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	src/shared/platform/posix/nacl_host_desc.c	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	2 chunks	+64 lines, -0 lines	0 comments	Download
M	src/shared/platform/win/nacl_host_desc.c	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	6 chunks	+119 lines, -19 lines	0 comments	Download
M	src/shared/platform/win/nacl_host_dir.c	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23	1 chunk	+36 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_base.h	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_base.c	View		2 chunks	+51 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_cond.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_conn_cap.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_custom.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_dir.c	View		2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_imc.c	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_imc_bound_desc.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_imc_shm.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_invalid.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_io.c	View	1 2 3 4	2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_mutex.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_null.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_quota.c	View		2 chunks	+37 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_semaphore.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_sync_socket.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/posix/nacl_desc_conn_cap.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/desc/posix/nacl_desc_imc_bound_desc.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/include/bits/nacl_syscalls.h	View	3	3 chunks	+7 lines, -1 line	0 comments	Download
M	src/trusted/service_runtime/include/sys/time.h	View	1 2 3 4 5 6	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/include/sys/unistd.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/trusted/service_runtime/nacl_syscall_list.c	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/sys_fdio.h	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/sys_fdio.c	View		1 chunk	+123 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/sys_filename.c	View	1 2 3 4	1 chunk	+26 lines, -12 lines	0 comments	Download
M	src/untrusted/irt/irt_dev.h	View	1 2 3 4	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/untrusted/irt/irt_fdio.c	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/untrusted/irt/irt_filename.c	View	3 4	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/untrusted/irt/irt_interfaces.c	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/untrusted/nacl/syscall_bindings_trampoline.h	View	1 2 3 4 5 6 7	3 chunks	+13 lines, -0 lines	0 comments	Download
M	tests/syscalls/nacl.scons	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/syscalls/syscalls.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	11 chunks	+225 lines, -29 lines	0 comments	Download