Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/x87/full-codegen-x87.cc

Issue 1235603002: Debugger: make debug code on-stack replacement more robust. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix arm64 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x87/full-codegen-x87.cc
diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc
index 7b1a35dcd72d1dae92c8d8f5827dcebcd9957c52..de73a067bb7084050c2c89f0e99b07987630bf99 100644
--- a/src/x87/full-codegen-x87.cc
+++ b/src/x87/full-codegen-x87.cc
@@ -2071,8 +2071,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
Label suspend, continuation, post_runtime, resume;
__ jmp(&suspend);
-
__ bind(&continuation);
+ __ RecordGeneratorContinuation();
__ jmp(&resume);
__ bind(&suspend);
@@ -2145,9 +2145,12 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
EnterTryBlock(handler_index, &l_catch);
const int try_block_size = TryCatch::kElementCount * kPointerSize;
__ push(eax); // result
+
__ jmp(&l_suspend);
__ bind(&l_continuation);
+ __ RecordGeneratorContinuation();
__ jmp(&l_resume);
+
__ bind(&l_suspend);
const int generator_object_depth = kPointerSize + try_block_size;
__ mov(eax, Operand(esp, generator_object_depth));

Powered by Google App Engine
This is Rietveld 408576698