Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/arm64/assembler-arm64.cc

Issue 1235603002: Debugger: make debug code on-stack replacement more robust. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/assembler-arm64.h ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // 2 //
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are 4 // modification, are permitted provided that the following conditions are
5 // met: 5 // met:
6 // 6 //
7 // * Redistributions of source code must retain the above copyright 7 // * Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // * Redistributions in binary form must reproduce the above 9 // * Redistributions in binary form must reproduce the above
10 // copyright notice, this list of conditions and the following 10 // copyright notice, this list of conditions and the following
(...skipping 2887 matching lines...) Expand 10 before | Expand all | Expand 10 after
2898 } 2898 }
2899 2899
2900 2900
2901 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 2901 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
2902 // We do not try to reuse pool constants. 2902 // We do not try to reuse pool constants.
2903 RelocInfo rinfo(reinterpret_cast<byte*>(pc_), rmode, data, NULL); 2903 RelocInfo rinfo(reinterpret_cast<byte*>(pc_), rmode, data, NULL);
2904 if (((rmode >= RelocInfo::JS_RETURN) && 2904 if (((rmode >= RelocInfo::JS_RETURN) &&
2905 (rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL)) || 2905 (rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL)) ||
2906 (rmode == RelocInfo::INTERNAL_REFERENCE) || 2906 (rmode == RelocInfo::INTERNAL_REFERENCE) ||
2907 (rmode == RelocInfo::CONST_POOL) || (rmode == RelocInfo::VENEER_POOL) || 2907 (rmode == RelocInfo::CONST_POOL) || (rmode == RelocInfo::VENEER_POOL) ||
2908 (rmode == RelocInfo::DEOPT_REASON)) { 2908 (rmode == RelocInfo::DEOPT_REASON) ||
2909 (rmode == RelocInfo::GENERATOR_CONTINUATION)) {
2909 // Adjust code for new modes. 2910 // Adjust code for new modes.
2910 DCHECK(RelocInfo::IsDebugBreakSlot(rmode) 2911 DCHECK(RelocInfo::IsDebugBreakSlot(rmode) || RelocInfo::IsJSReturn(rmode) ||
2911 || RelocInfo::IsJSReturn(rmode) 2912 RelocInfo::IsComment(rmode) || RelocInfo::IsDeoptReason(rmode) ||
2912 || RelocInfo::IsComment(rmode) 2913 RelocInfo::IsPosition(rmode) ||
2913 || RelocInfo::IsDeoptReason(rmode) 2914 RelocInfo::IsInternalReference(rmode) ||
2914 || RelocInfo::IsPosition(rmode) 2915 RelocInfo::IsConstPool(rmode) || RelocInfo::IsVeneerPool(rmode) ||
2915 || RelocInfo::IsInternalReference(rmode) 2916 RelocInfo::IsGeneratorContinuation(rmode));
2916 || RelocInfo::IsConstPool(rmode)
2917 || RelocInfo::IsVeneerPool(rmode));
2918 // These modes do not need an entry in the constant pool. 2917 // These modes do not need an entry in the constant pool.
2919 } else { 2918 } else {
2920 constpool_.RecordEntry(data, rmode); 2919 constpool_.RecordEntry(data, rmode);
2921 // Make sure the constant pool is not emitted in place of the next 2920 // Make sure the constant pool is not emitted in place of the next
2922 // instruction for which we just recorded relocation info. 2921 // instruction for which we just recorded relocation info.
2923 BlockConstPoolFor(1); 2922 BlockConstPoolFor(1);
2924 } 2923 }
2925 2924
2926 if (!RelocInfo::IsNone(rmode)) { 2925 if (!RelocInfo::IsNone(rmode)) {
2927 // Don't record external references unless the heap will be serialized. 2926 // Don't record external references unless the heap will be serialized.
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
3171 movk(scratch, (target_offset >> 32) & 0xFFFF, 32); 3170 movk(scratch, (target_offset >> 32) & 0xFFFF, 32);
3172 DCHECK((target_offset >> 48) == 0); 3171 DCHECK((target_offset >> 48) == 0);
3173 add(rd, rd, scratch); 3172 add(rd, rd, scratch);
3174 } 3173 }
3175 3174
3176 3175
3177 } // namespace internal 3176 } // namespace internal
3178 } // namespace v8 3177 } // namespace v8
3179 3178
3180 #endif // V8_TARGET_ARCH_ARM64 3179 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/assembler-arm64.h ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698