content/browser/renderer_host/gpu_message_filter.cc - Issue 12356002: [NOT FOR COMMIT] Hacks to merge render compositor thread with UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/gpu_message_filter.cc

Issue 12356002: [NOT FOR COMMIT] Hacks to merge render compositor thread with UI thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: New thread restriction allows (incomplete patch) Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/scoped_allow_wait_for_legacy_web_view_api.h ('K') | « content/browser/browser_main_loop.cc ('k') | content/common/gpu/client/command_buffer_proxy_impl.cc » ('j') | content/common/gpu/client/command_buffer_proxy_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/gpu_message_filter.cc

diff --git a/content/browser/renderer_host/gpu_message_filter.cc b/content/browser/renderer_host/gpu_message_filter.cc

index a25d5a46c1b53f6fd0c5e64807f628699e0f1f26..62fad9a7cd97864a82a4ecb72aef7475b85585b3 100644

--- a/content/browser/renderer_host/gpu_message_filter.cc

+++ b/content/browser/renderer_host/gpu_message_filter.cc

@@ -151,6 +151,8 @@ void GpuMessageFilter::OnCreateViewCommandBuffer(

// If the current handle for the surface is using a different (older) gpu

// host, it means the GPU process died and we need to wait until the UI

// re-allocates the surface in the new process.

+ // TODO(boliu): This will deadlock with threads merged. Can this ever

boliu 2013/03/01 00:19:12 So GpuHostMsg_CreateViewCommandBuffer is sent from

+ // happen?

linked_ptr<CreateViewCommandBufferRequest> request(

new CreateViewCommandBufferRequest(surface_id, init_params, reply));

pending_requests_.push_back(request);