Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Issue 1235563007: Simplify taskqueue interface. (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Simplify taskqueue interface. The removed complexity was a holdover from the initial versions of this library. R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/83bb08d7ae9bd07fedc3b932b104fc8c9a26e50f

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
M go/src/infra/gae/libs/gae/memory/taskqueue_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/gae/libs/gae/taskqueue.go View 1 chunk +2 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
iannucci
5 years, 5 months ago (2015-07-16 23:02:01 UTC) #1
iannucci
On 2015/07/16 23:02:01, iannucci wrote: PTAL, this one's short
5 years, 5 months ago (2015-07-16 23:02:19 UTC) #2
Vadim Sh.
lgtm
5 years, 5 months ago (2015-07-16 23:02:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235563007/20001
5 years, 5 months ago (2015-07-16 23:04:26 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 23:07:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/83bb08d7ae9bd07fedc3b932b104f...

Powered by Google App Engine
This is Rietveld 408576698