LayoutTests/http/tests/security/resources/referrer-policy-conflicting-policies.html - Issue 1235563004: Apply meta tag referrer policy for preloaded requests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/resources/referrer-policy-conflicting-policies.html

Issue 1235563004: Apply meta tag referrer policy for preloaded requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix conflicting policies test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/security/referrer-policy-subresource.html ('k') | LayoutTests/http/tests/security/resources/referrer-policy-script.php » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <head></head>

2 <script>	3 <script>

3 if (window.testRunner)	4 if (window.testRunner)

4 testRunner.setAllowDisplayOfInsecureContent(true);	5 testRunner.setAllowDisplayOfInsecureContent(true);

5	6

6 function done()	7 function done()

7 {	8 {

8 if (window.testRunner)	9 if (window.testRunner)

9 testRunner.notifyDone();	10 testRunner.notifyDone();

10 }	11 }

11 </script>	12 </script>

12 <style>	13 <style>

13 test {	14 test {

14 content: url("http://127.0.0.1:8080/security/resources/green-if-no-referrer. php");	15 content: url("http://127.0.0.1:8080/security/resources/green-if-no-referrer. php");

15 }	16 }

16 </style>	17 </style>

17 <meta name="referrer" content="origin" />	18 <script>
	estark 2015/07/14 04:45:35 I think (?) this change preserves what the test is I think (?) this change preserves what the test is trying to test (setting a document policy after a request is created). But something seems a little funky... after making this change, I looked at the original commit that introduced this test (https://chromium.googlesource.com/chromium/blink/+/b500b3f99d86bd5ff36764ca83...) and tried to verify that the test still tests what it's supposed to test by undoing the FrameFetchContext change in b500b3f99d. That is, I changed https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... to use m_document->referrerPolicy() instead of request.referrerPolicy() and was hoping to see the assertion fail on this test... but it didn't fail, either before or after my change here. So I'm not sure the test was testing what it was supposed to test. I wonder if we should replace it with a unit test for FrameFetchContext::addAdditionalRequestHeaders()?
	19 var meta = document.createElement("meta");

	20 meta.name = "referrer";

	21 meta.content = "origin";

	22 document.getElementsByTagName("head")[0].appendChild(meta);

	23 </script>

18 <body onload="done();">	24 <body onload="done();">

19 <p>	25 <p>

20 Checks that an CSS image that was created before a referrer policy was set is	26 Checks that an CSS image that was created before a referrer policy was set is

21 loaded with the correct referrer, in this case, without a referrer.	27 loaded with the correct referrer, in this case, without a referrer.

22 </p>	28 </p>

23 <p>	29 <p>

24 The test passes, if a green rectangle is displayed below.	30 The test passes, if a green rectangle is displayed below.

25 </p>	31 </p>

26 <test/>	32 <test/>

27 </body>	33 </body>

OLD	NEW