pkg/dart2js_incremental/lib/caching_compiler.dart - Issue 1235563003: Add interfaces for a new compiler API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 1235563003: Add interfaces for a new compiler API. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Rebased Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dart2js_incremental/lib/caching_compiler.dart

diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart

index aeab05acc6176c37e8c6c70bb0e19cdff83bc1db..b041c00cfcaaf3e3bcce845f677198981a3710f6 100644

--- a/pkg/dart2js_incremental/lib/caching_compiler.dart

+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart

@@ -7,9 +7,9 @@ part of dart2js_incremental;

/// Do not call this method directly. It will be made private.

// TODO(ahe): Make this method private.

Future<Compiler> reuseCompiler(

- {DiagnosticHandler diagnosticHandler,

- CompilerInputProvider inputProvider,

- CompilerOutputProvider outputProvider,

+ {CompilerDiagnostics diagnosticHandler,

+ CompilerInput inputProvider,

+ CompilerOutput outputProvider,

List<String> options: const [],

Compiler cachedCompiler,

Uri libraryRoot,