Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 1235563002: [arm64] Fixed unnecessary environment assignment to LSmiTag instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-490021.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #include "src/arm64/lithium-codegen-arm64.h" 9 #include "src/arm64/lithium-codegen-arm64.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 1185 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 return AssignPointerMap(DefineAsRegister(result)); 1196 return AssignPointerMap(DefineAsRegister(result));
1197 } else { 1197 } else {
1198 STATIC_ASSERT((kMinInt == Smi::kMinValue) && 1198 STATIC_ASSERT((kMinInt == Smi::kMinValue) &&
1199 (kMaxInt == Smi::kMaxValue)); 1199 (kMaxInt == Smi::kMaxValue));
1200 LOperand* value = UseRegisterAtStart(val); 1200 LOperand* value = UseRegisterAtStart(val);
1201 return DefineAsRegister(new(zone()) LSmiTag(value)); 1201 return DefineAsRegister(new(zone()) LSmiTag(value));
1202 } 1202 }
1203 } else if (to.IsSmi()) { 1203 } else if (to.IsSmi()) {
1204 LOperand* value = UseRegisterAtStart(val); 1204 LOperand* value = UseRegisterAtStart(val);
1205 LInstruction* result = DefineAsRegister(new(zone()) LSmiTag(value)); 1205 LInstruction* result = DefineAsRegister(new(zone()) LSmiTag(value));
1206 if (val->CheckFlag(HInstruction::kUint32)) { 1206 if (instr->CheckFlag(HValue::kCanOverflow)) {
1207 result = AssignEnvironment(result); 1207 result = AssignEnvironment(result);
1208 } 1208 }
1209 return result; 1209 return result;
1210 } else { 1210 } else {
1211 DCHECK(to.IsDouble()); 1211 DCHECK(to.IsDouble());
1212 if (val->CheckFlag(HInstruction::kUint32)) { 1212 if (val->CheckFlag(HInstruction::kUint32)) {
1213 return DefineAsRegister( 1213 return DefineAsRegister(
1214 new(zone()) LUint32ToDouble(UseRegisterAtStart(val))); 1214 new(zone()) LUint32ToDouble(UseRegisterAtStart(val)));
1215 } else { 1215 } else {
1216 return DefineAsRegister( 1216 return DefineAsRegister(
(...skipping 1566 matching lines...) Expand 10 before | Expand all | Expand 10 after
2783 LOperand* context = UseFixed(instr->context(), cp); 2783 LOperand* context = UseFixed(instr->context(), cp);
2784 LOperand* function = UseRegisterAtStart(instr->function()); 2784 LOperand* function = UseRegisterAtStart(instr->function());
2785 LAllocateBlockContext* result = 2785 LAllocateBlockContext* result =
2786 new(zone()) LAllocateBlockContext(context, function); 2786 new(zone()) LAllocateBlockContext(context, function);
2787 return MarkAsCall(DefineFixed(result, cp), instr); 2787 return MarkAsCall(DefineFixed(result, cp), instr);
2788 } 2788 }
2789 2789
2790 2790
2791 } // namespace internal 2791 } // namespace internal
2792 } // namespace v8 2792 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-490021.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698