Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1235533004: Revert of Added a GLBench for testing performance of vec4 vs scalar... (Closed)

Created:
5 years, 5 months ago by scroggo
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Added a GLBench for testing performance of vec4 vs scalar for coverage in generated shaders. (patchset #4 id:40002 of https://codereview.chromium.org/1225383002/) Reason for revert: This is breaking a buildbot. See https://chromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Debug-ANGLE/builds/172/steps/nanobench/logs/stdio We get the following error: ERROR::SHADER::COMPLIATION_FAILED: ERROR: 0:8: '0.f' : Floating-point suffix unsupported prior to GLSL ES 3.00 ERROR: 0:8: '0.f' : syntax error Original issue's description: > Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders. > > Added bench for timing vec4 vs scalar type for coverage in shaders > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6104ced165f17eb2f765ace354d5895c0bc890c5 TBR=joshualitt@google.com,tomhudson@google.com,wangyix@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cd8c499f2e5126a8b5edee09d0debd8d298210fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -308 lines) Patch
D bench/GLVec4ScalarBench.cpp View 1 chunk +0 lines, -308 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scroggo
Created Revert of Added a GLBench for testing performance of vec4 vs scalar for coverage ...
5 years, 5 months ago (2015-07-13 19:03:15 UTC) #1
tomhudson
5 years, 5 months ago (2015-07-13 19:04:25 UTC) #2
Message was sent while issue was closed.
On 2015/07/13 19:03:15, scroggo wrote:
> Created Revert of Added a GLBench for testing performance of vec4 vs scalar
for
> coverage in generated shaders.

Thanks, Leon.

LGTM :(

Powered by Google App Engine
This is Rietveld 408576698