Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 123553005: Added new server/cmdline/io programmers' guide. (Closed)

Created:
6 years, 11 months ago by mem
Modified:
6 years, 11 months ago
Reviewers:
Shams
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Added new server/cmdline/io programmers' guide. BUG= R=shaza@google.com Committed: 014f98b

Patch Set 1 #

Total comments: 8

Patch Set 2 : changes based on shaza's comments #

Patch Set 3 : fixed overlapping sidebar problem with new layout file #

Patch Set 4 : used new page layout for new tutorial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -17 lines) Patch
A + src/site/_layouts/tutorial.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/index.markdown View 1 chunk +4 lines, -3 lines 0 comments Download
A src/site/docs/serverguide.markdown View 1 1 chunk +149 lines, -0 lines 0 comments Download
M src/site/docs/tutorials/add-elements/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/cmdline/index.markdown View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/site/docs/tutorials/connect-dart-html/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/fetchdata/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/forms/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/futures/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/get-started/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/indexeddb/index.markdown View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/polymer-intro/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/remove-elements/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/shared-pkgs/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/tutorials/streams/index.markdown View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mem
Please review. The new file is hosted here: https://mem-prog-guide-dot-dart-lang.appspot.com/docs/serverguide.html (the link to the new cmdline ...
6 years, 11 months ago (2014-01-03 00:09:32 UTC) #1
Shams
LGTM with just a few minor things. https://codereview.chromium.org/123553005/diff/1/src/site/docs/serverguide.markdown File src/site/docs/serverguide.markdown (right): https://codereview.chromium.org/123553005/diff/1/src/site/docs/serverguide.markdown#newcode16 src/site/docs/serverguide.markdown:16: If you ...
6 years, 11 months ago (2014-01-03 00:28:17 UTC) #2
mem
Thanks for your comments. https://codereview.chromium.org/123553005/diff/1/src/site/docs/serverguide.markdown File src/site/docs/serverguide.markdown (right): https://codereview.chromium.org/123553005/diff/1/src/site/docs/serverguide.markdown#newcode16 src/site/docs/serverguide.markdown:16: If you prefer to plow ...
6 years, 11 months ago (2014-01-03 00:35:02 UTC) #3
mem
6 years, 11 months ago (2014-01-03 19:34:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r014f98b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698