Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 123553003: Added memory and V8 metrics to indexeddb_perf results (Closed)

Created:
6 years, 11 months ago by cmumford
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-results
Visibility:
Public.

Description

Added memory and V8 metrics to indexeddb_perf results We are trying to deprecate the page_cycler.indexeddb performance test. One of the things done by that test and not indexeddb_perf is the measurement of V8 memory statistics. This change brings V8 stats into indexeddb_perf - but only a subset of the full measurements. Opted for a smaller subset as the full set has too much unrelated stuff, and we really want to catch things like unreleased objects, etc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M tools/perf/benchmarks/indexeddb_perf.py View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cmumford
Sample results at http://cmumford.mtv.corp.google.com/idb-perf-with-v8-results.html
6 years, 11 months ago (2014-01-09 17:39:40 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-09 17:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/123553003/1
6 years, 11 months ago (2014-01-09 22:05:41 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 02:35:26 UTC) #4
Message was sent while issue was closed.
Change committed as 244054

Powered by Google App Engine
This is Rietveld 408576698