Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: pkg/compiler/lib/src/js_backend/minify_namer.dart

Issue 1235463004: dart2js: Take named arguments into account (again) when naming one-shot interceptors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix date Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/minify_namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/minify_namer.dart b/pkg/compiler/lib/src/js_backend/minify_namer.dart
index dd01a92fb34f531e188637576f64ecabe856a1ab..3e9ae73ba3252a544b17c774eeb92f4afd170eb5 100644
--- a/pkg/compiler/lib/src/js_backend/minify_namer.dart
+++ b/pkg/compiler/lib/src/js_backend/minify_namer.dart
@@ -342,9 +342,10 @@ abstract class _MinifiedOneShotInterceptorNamer implements Namer {
String prefix = selector.isGetter
? r"$get"
: selector.isSetter ? r"$set" : "";
- String arity = selector.isCall ? "${selector.argumentCount}" : "";
+ String callSuffix =
+ selector.isCall ? callSuffixForStructure(selector.callStructure) : "";
String suffix = suffixForGetInterceptor(classes);
- String fullName = "\$intercepted$prefix\$$root$arity\$$suffix";
+ String fullName = "\$intercepted$prefix\$$root$callSuffix\$$suffix";
return _disambiguateInternalGlobal(fullName);
}
}
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698