Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1235443002: Support for icon theming (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 2

Patch Set 3 : Move icon_theme into icon.dart #

Patch Set 4 : fix tests #

Patch Set 5 : rebase and fix analyzer warning #

Patch Set 6 : fix analyzer warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -86 lines) Patch
M sky/sdk/example/fitness/lib/home.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/example/fitness/lib/settings.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/stocks/lib/main.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_home.dart View 1 2 3 4 5 chunks +16 lines, -5 lines 0 comments Download
M sky/sdk/example/widgets/tabs.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/theme/colors.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/sdk/lib/theme/theme_data.dart View 1 2 3 4 3 chunks +12 lines, -25 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 2 3 chunks +21 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/icon.dart View 1 2 3 3 chunks +52 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 2 chunks +1 line, -10 lines 0 comments Download
M sky/sdk/lib/widgets/tabs.dart View 1 2 3 3 chunks +37 lines, -14 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 2 3 4 5 4 chunks +23 lines, -5 lines 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Hixie
lgtm yeah this is way better. https://codereview.chromium.org/1235443002/diff/20001/sky/sdk/lib/widgets/icon_theme.dart File sky/sdk/lib/widgets/icon_theme.dart (right): https://codereview.chromium.org/1235443002/diff/20001/sky/sdk/lib/widgets/icon_theme.dart#newcode1 sky/sdk/lib/widgets/icon_theme.dart:1: // Copyright 2015 ...
5 years, 5 months ago (2015-07-09 23:06:08 UTC) #1
jackson
https://codereview.chromium.org/1235443002/diff/20001/sky/sdk/lib/widgets/icon_theme.dart File sky/sdk/lib/widgets/icon_theme.dart (right): https://codereview.chromium.org/1235443002/diff/20001/sky/sdk/lib/widgets/icon_theme.dart#newcode1 sky/sdk/lib/widgets/icon_theme.dart:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
5 years, 5 months ago (2015-07-09 23:16:19 UTC) #2
jackson
5 years, 5 months ago (2015-07-10 18:14:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
5e8baea94d2beec1530bd095d12ea9e8ee02fafc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698