Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: media/base/decoder_buffer.h

Issue 1235403002: Change ChunkDemuxerStream/SourceBufferStream memory limit to size_t type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A few more minor fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/chunk_demuxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/decoder_buffer.h
diff --git a/media/base/decoder_buffer.h b/media/base/decoder_buffer.h
index 665313ddcc1a698a23452c706355c80ed99f98d3..327eef3f9846686e897c694eba4077352b62c19d 100644
--- a/media/base/decoder_buffer.h
+++ b/media/base/decoder_buffer.h
@@ -96,6 +96,7 @@ class MEDIA_EXPORT DecoderBuffer
return data_.get();
}
+ // TODO(servolk): data_size should return size_t instead of int
int data_size() const {
DCHECK(!end_of_stream());
return size_;
@@ -106,6 +107,7 @@ class MEDIA_EXPORT DecoderBuffer
return side_data_.get();
}
+ // TODO(servolk): side_data_size should return size_t instead of int
int side_data_size() const {
DCHECK(!end_of_stream());
return side_data_size_;
@@ -187,6 +189,7 @@ class MEDIA_EXPORT DecoderBuffer
base::TimeDelta timestamp_;
base::TimeDelta duration_;
+ // TODO(servolk): Consider changing size_/side_data_size_ types to size_t.
int size_;
scoped_ptr<uint8, base::AlignedFreeDeleter> data_;
int side_data_size_;
« no previous file with comments | « no previous file | media/filters/chunk_demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698