Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1235393004: Use standard harmony flag (Closed)

Created:
5 years, 5 months ago by vsm
Modified:
5 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use standard harmony flag This fixes current breakage with Chrome 46. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5e6b21eef74c1ad1c8ef3e933afd128eabf74613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M USAGE.md View 1 chunk +1 line, -1 line 0 comments Download
M karma.conf.js View 1 chunk +1 line, -4 lines 0 comments Download
M lib/runtime/harmony_feature_check.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 5 months ago (2015-07-16 16:30:24 UTC) #2
Jennifer Messerly
lgtm!
5 years, 5 months ago (2015-07-16 16:32:47 UTC) #3
vsm
5 years, 5 months ago (2015-07-16 16:33:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e6b21eef74c1ad1c8ef3e933afd128eabf74613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698