Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235393003: guard to remove DrawBitmapRectFlags (Closed)

Created:
5 years, 5 months ago by reed2
Modified:
5 years, 5 months ago
Reviewers:
f(malita), djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

guard to remove DrawBitmapRectFlags BUG=skia: Committed: https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -50 lines) Patch
M bench/BitmapRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GameBench.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/bitmaprect.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/drawbitmaprect.cpp View 4 chunks +10 lines, -15 lines 0 comments Download
M gm/tallstretchedbitmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 1 comment Download
M include/core/SkCanvas.h View 5 chunks +17 lines, -5 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleBitmapRect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleTextureDomain.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +14 lines, -0 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkNinePatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235393003/1
5 years, 5 months ago (2015-07-16 04:07:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-16 04:15:53 UTC) #4
reed2
ptal
5 years, 5 months ago (2015-07-16 12:03:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235393003/1
5 years, 5 months ago (2015-07-16 12:04:05 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-16 12:04:07 UTC) #9
f(malita)
lgtm
5 years, 5 months ago (2015-07-16 13:07:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d
5 years, 5 months ago (2015-07-16 13:10:07 UTC) #11
djsollen
https://codereview.chromium.org/1235393003/diff/1/gyp/skia_for_android_framework_defines.gypi File gyp/skia_for_android_framework_defines.gypi (right): https://codereview.chromium.org/1235393003/diff/1/gyp/skia_for_android_framework_defines.gypi#newcode24 gyp/skia_for_android_framework_defines.gypi:24: 'SK_SUPPORT_LEGACY_DRAWBITMAPRECTFLAGS_TYPE', this is breaking the android framework build!
5 years, 5 months ago (2015-07-17 12:36:00 UTC) #13
scroggo
5 years, 5 months ago (2015-07-17 12:57:21 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1230823007/ by scroggo@google.com.

The reason for reverting is: breaking android framework build.

Powered by Google App Engine
This is Rietveld 408576698