chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 1235383002: Stop UI jumping when clicking Contextual Search Results in Custom Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1235383002: Stop UI jumping when clicking Contextual Search Results in Custom Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index efeef0faa2af439ad728ccd13b87159087bf80c6..5c58b94a9516fe708b3df7c0af8f012272716f09 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -236,6 +236,7 @@ public class CustomTabActivity extends ChromeActivity {

@Override

public boolean createContextualSearchTab(ContentViewCore searchContentViewCore) {

if (mTab == null) return false;

+ getCurrentContentViewCore().clearSelection();

NavigationEntry entry =

searchContentViewCore.getWebContents().getNavigationController().getPendingEntry();

String url = entry != null

« chrome/android/java/res/values-v17/styles.xml ('K') | « chrome/android/java/res/values-v17/styles.xml ('k') | no next file » | no next file with comments »