chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java - Issue 1235373006: Upstream changes for NetworkQualityProvider

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Issue 1235373006: Upstream changes for NetworkQualityProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/NetworkQualityProvider.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/NetworkQualityProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

index 3eff68e9a270b2922d8d0bc8dfb872f5b0e5cd88..ace4570a7ee71e242aff180187c5dbf31f4ec1f6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

@@ -55,6 +55,7 @@ import org.chromium.chrome.browser.invalidation.UniqueIdInvalidationClientNameGe

import org.chromium.chrome.browser.metrics.UmaUtils;

import org.chromium.chrome.browser.metrics.VariationsSession;

import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;

+import org.chromium.chrome.browser.net.qualityprovider.NetworkQualityProvider;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

import org.chromium.chrome.browser.omaha.RequestGenerator;

import org.chromium.chrome.browser.omaha.UpdateInfoBarHelper;

@@ -435,6 +436,7 @@ public class ChromeApplication extends ContentApplication {

RevenueStats.getInstance();

getPKCS11AuthenticationManager().initialize(ChromeApplication.this);

+ getNetworkQualityProvider().initialize(ChromeApplication.this);

nyquist 2015/07/22 14:46:59 Why |ChromeApplication.|?

tbansal1 2015/07/22 21:11:29 I don't think it matters. I was just being consist

mDevToolsServer = new DevToolsServer(DEV_TOOLS_SERVER_SOCKET_PREFIX);

mDevToolsServer.setRemoteDebuggingEnabled(

@@ -585,6 +587,13 @@ public class ChromeApplication extends ContentApplication {

}

/**

+ * @return A provider of network quality.

+ */

+ public NetworkQualityProvider getNetworkQualityProvider() {

+ return NetworkQualityProvider.getInstance();

nyquist 2015/07/22 14:46:59 Could this instead just create the object and pass

tbansal1 2015/07/22 21:11:29 Done.

+ }

+ /**

* @return The user agent string of Chrome.

public static String getBrowserUserAgent() {