Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Issue 1235353002: Fix resolution of local branch name in scm and rebaseline tools. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: also check for detached HEAD in rebaseline-o-matic Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1061 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 self.command.tree_status = lambda: 'closed' 1072 self.command.tree_status = lambda: 'closed'
1073 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1073 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1074 self.assertEqual(self.tool.executive.calls, []) 1074 self.assertEqual(self.tool.executive.calls, [])
1075 1075
1076 self.command.tree_status = lambda: 'open' 1076 self.command.tree_status = lambda: 'open'
1077 self.tool.executive.calls = [] 1077 self.tool.executive.calls = []
1078 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1078 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1079 1079
1080 self.assertEqual(self.tool.executive.calls, [ 1080 self.assertEqual(self.tool.executive.calls, [
1081 self.SVN_REMOTE_CMD, 1081 self.SVN_REMOTE_CMD,
1082 ['git', 'rev-parse', '--symbolic-full-name', 'HEAD'],
1083 [ 1082 [
1084 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt,png', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-c hocolate.html'], 1083 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt,png', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-c hocolate.html'],
1085 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'png', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-s trawberry.html'], 1084 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'png', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-s trawberry.html'],
1086 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco. html'], 1085 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco. html'],
1087 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-t aco.html'], 1086 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-t aco.html'],
1088 ], 1087 ],
1089 [ 1088 [
1090 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt,png', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-chocolate .html'], 1089 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt,png', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-chocolate .html'],
1091 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'png', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-strawberr y.html'], 1090 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'png', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-strawberr y.html'],
1092 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco.html'], 1091 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco.html'],
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 1159
1161 self.command.SECONDS_BEFORE_GIVING_UP = 0 1160 self.command.SECONDS_BEFORE_GIVING_UP = 0
1162 self.command.tree_status = lambda: 'open' 1161 self.command.tree_status = lambda: 'open'
1163 self.tool.executive = MockExecutive( 1162 self.tool.executive = MockExecutive(
1164 should_return_zero_when_run=set(self.SVN_REMOTE_CMD)) 1163 should_return_zero_when_run=set(self.SVN_REMOTE_CMD))
1165 self.tool.executive.calls = [] 1164 self.tool.executive.calls = []
1166 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1165 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1167 1166
1168 self.assertEqual(self.tool.executive.calls, [ 1167 self.assertEqual(self.tool.executive.calls, [
1169 self.SVN_REMOTE_CMD, 1168 self.SVN_REMOTE_CMD,
1170 ['git', 'rev-parse', '--symbolic-full-name', 'HEAD'],
1171 [ 1169 [
1172 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-t aco.html'], 1170 ['python', 'echo', 'copy-existing-baselines-internal', '--su ffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-t aco.html'],
1173 ], 1171 ],
1174 [ 1172 [
1175 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-taco.html '], 1173 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-taco.html '],
1176 ], 1174 ],
1177 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', 'txt', 'fast/dom/prototype-taco.html']], 1175 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', 'txt', 'fast/dom/prototype-taco.html']],
1178 ['git', 'cl', 'upload', '-f'], 1176 ['git', 'cl', 'upload', '-f'],
1179 ]) 1177 ])
1180 finally: 1178 finally:
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1222 try: 1220 try:
1223 builders._exact_matches = { 1221 builders._exact_matches = {
1224 "MOCK Leopard": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"])}, 1222 "MOCK Leopard": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"])},
1225 "MOCK SnowLeopard": {"port_name": "test-mac-snowleopard", "speci fiers": set(["mock-specifier"])}, 1223 "MOCK SnowLeopard": {"port_name": "test-mac-snowleopard", "speci fiers": set(["mock-specifier"])},
1226 } 1224 }
1227 1225
1228 self.command.tree_status = lambda: 'open' 1226 self.command.tree_status = lambda: 'open'
1229 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1227 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1230 self.assertEqual(self.tool.executive.calls, [ 1228 self.assertEqual(self.tool.executive.calls, [
1231 self.SVN_REMOTE_CMD, 1229 self.SVN_REMOTE_CMD,
1232 ['git', 'rev-parse', '--symbolic-full-name', 'HEAD'],
1233 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']], 1230 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']],
1234 ['git', 'cl', 'upload', '-f'], 1231 ['git', 'cl', 'upload', '-f'],
1235 ['git', 'pull'], 1232 ['git', 'pull'],
1236 ['git', 'cl', 'dcommit', '-f'], 1233 ['git', 'cl', 'dcommit', '-f'],
1237 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'], 1234 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'],
1238 ['git', 'cl', 'set_close'], 1235 ['git', 'cl', 'set_close'],
1239 ]) 1236 ])
1240 1237
1241 # The mac ports should both be removed since they're the only ones i n builders._exact_matches. 1238 # The mac ports should both be removed since they're the only ones i n builders._exact_matches.
1242 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1239 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 try: 1283 try:
1287 builders._exact_matches = { 1284 builders._exact_matches = {
1288 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])}, 1285 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])},
1289 } 1286 }
1290 1287
1291 self.command.tree_status = lambda: 'open' 1288 self.command.tree_status = lambda: 'open'
1292 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1289 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1293 self.assertEqual(self.tool.executive.calls, [ 1290 self.assertEqual(self.tool.executive.calls, [
1294 self.SVN_REMOTE_CMD, 1291 self.SVN_REMOTE_CMD,
1295 ['git', 'auto-svn'], 1292 ['git', 'auto-svn'],
1296 ['git', 'rev-parse', '--symbolic-full-name', 'HEAD'],
1297 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']], 1293 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']],
1298 ['git', 'cl', 'upload', '-f'], 1294 ['git', 'cl', 'upload', '-f'],
1299 ['git', 'pull'], 1295 ['git', 'pull'],
1300 ['git', 'cl', 'dcommit', '-f'], 1296 ['git', 'cl', 'dcommit', '-f'],
1301 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'], 1297 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'],
1302 ['git', 'cl', 'set_close'], 1298 ['git', 'cl', 'set_close'],
1303 ]) 1299 ])
1304 1300
1305 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1301 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
1306 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ] 1302 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ]
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
1350 oc.capture_output() 1346 oc.capture_output()
1351 self.command._do_one_rebaseline() 1347 self.command._do_one_rebaseline()
1352 out, _, _ = oc.restore_output() 1348 out, _, _ = oc.restore_output()
1353 1349
1354 self.assertEqual(out, 'MOCK STDOUT\n') 1350 self.assertEqual(out, 'MOCK STDOUT\n')
1355 self.assertEqual(self.tool.executive.calls, [ 1351 self.assertEqual(self.tool.executive.calls, [
1356 ['git', 'pull'], 1352 ['git', 'pull'],
1357 ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkit-patch', 'au to-rebaseline', '--verbose'], 1353 ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkit-patch', 'au to-rebaseline', '--verbose'],
1358 ]) 1354 ])
1359 self.assertEqual(self._logs, ['MOCK STDOUT']) 1355 self.assertEqual(self._logs, ['MOCK STDOUT'])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698