Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1235313002: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, picksi1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. The InterpreterAssembler needs to specify a specific CallDescriptor type instead of using the SimplifiedCDescriptor type. This CL makes it possible to specify the CallDescriptor used by the RawMachineAssembler instead of specifying a MachineSignature. Also removes instruction-selector-tester.h which was erroneously resurrected at some point. BUG=v8:4280 LOG=N Committed: https://crrev.com/fbe085fd754845d281c5f9adcae15beda8155fef Cr-Commit-Position: refs/heads/master@{#29777}

Patch Set 1 #

Total comments: 2

Patch Set 2 : instruction-selector-tester.h must die! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -158 lines) Patch
M src/compiler/raw-machine-assembler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/instruction-selector-tester.h View 1 1 chunk +0 lines, -127 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 3 chunks +20 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
rmcilroy
Benedikt: this change is required for https://codereview.chromium.org/1239793002/. Could you please take a look? Thanks.
5 years, 5 months ago (2015-07-15 16:57:00 UTC) #2
rmcilroy
On 2015/07/15 16:57:00, rmcilroy wrote: > Benedikt: this change is required for > https://codereview.chromium.org/1239793002/. Could ...
5 years, 5 months ago (2015-07-20 13:48:17 UTC) #3
rmcilroy
Michael, since Benedikt is OOO could you take a look at this please? It is ...
5 years, 5 months ago (2015-07-21 11:14:17 UTC) #5
Michael Starzinger
LGTM with one comment to address. https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h File test/cctest/compiler/instruction-selector-tester.h (right): https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h#newcode46 test/cctest/compiler/instruction-selector-tester.h:46: machine_sig)) {} There ...
5 years, 5 months ago (2015-07-21 11:46:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235313002/40001
5 years, 5 months ago (2015-07-21 15:16:54 UTC) #10
rmcilroy
https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h File test/cctest/compiler/instruction-selector-tester.h (right): https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h#newcode46 test/cctest/compiler/instruction-selector-tester.h:46: machine_sig)) {} On 2015/07/21 11:46:23, Michael Starzinger wrote: > ...
5 years, 5 months ago (2015-07-21 15:16:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-21 15:54:20 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:54:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbe085fd754845d281c5f9adcae15beda8155fef
Cr-Commit-Position: refs/heads/master@{#29777}

Powered by Google App Engine
This is Rietveld 408576698