Issue 1235293004: Fix server mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235293004: Fix server mode (Closed)

Created:
5 years, 5 months ago by vsm

Modified:
5 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix server mode TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e613c059ee987ab5bc4dcc2c5e2e1c3dc5db6769

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	lib/src/codegen/html_codegen.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	lib/src/server/server.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #1 (id:1) manually as e613c059ee987ab5bc4dcc2c5e2e1c3dc5db6769 (presubmit successful).

5 years, 5 months ago (2015-07-18 04:21:28 UTC) #1

Jennifer Messerly

5 years, 5 months ago (2015-07-20 15:03:19 UTC) #2

Message was sent while issue was closed.

lgtm, thanks! I tested it a bunch manually, but somehow got lost in the
refactoring towards the end. =|

I'll see if I can fix ./tool/analyzer.sh to cover this. I think we lost coverage
because it doesn't analyze ./bin/devc

Expand Messages | Collapse Messages