Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1235283004: Various GL testing fixes (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Various GL testing fixes Check for GL context when printing NVPR error string. Fix some indenting. Committed: https://skia.googlesource.com/skia/+/3e5f55542cbd23f1ad448cac3d29e8551204552c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M gm/imagefromyuvtextures.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 chunk +13 lines, -6 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
5 years, 5 months ago (2015-07-15 19:41:13 UTC) #2
jvanverth1
5 years, 5 months ago (2015-07-15 19:41:15 UTC) #3
bsalomon
lgtm
5 years, 5 months ago (2015-07-15 21:13:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235283004/1
5 years, 5 months ago (2015-07-16 14:38:33 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 14:46:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e5f55542cbd23f1ad448cac3d29e8551204552c

Powered by Google App Engine
This is Rietveld 408576698