Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1235273003: X87: Switch CallConstructStub to take new.target in register. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Switch CallConstructStub to take new.target in register. original commit message: This changes the calling convention of the CallConstructStub to take the original constructor (i.e. new.target in JS-speak) in a register instead of magically via the operand stack. For optimizing compilers the operand stack doesn't exist, hence cannot be peeked into. BUG= Committed: https://crrev.com/c6d42c7d6c60f0651ee993f2de5b59f37225732a Cr-Commit-Position: refs/heads/master@{#29695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-16 08:17:51 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-16 08:26:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235273003/1
5 years, 5 months ago (2015-07-16 08:26:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 08:52:58 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 08:53:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6d42c7d6c60f0651ee993f2de5b59f37225732a
Cr-Commit-Position: refs/heads/master@{#29695}

Powered by Google App Engine
This is Rietveld 408576698