Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1235233005: Add missing source to gn bootstrap. (Closed)

Created:
5 years, 5 months ago by Peter Mayo
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing source to gn bootstrap. This command is subject to bitrot, and this seems to be today's instance. BUG=510240 TEST=tools/gn/bootstrap/bootstrap.py R=dpranke@chromium.org Committed: https://crrev.com/d673f55c138f6b263375c096c43ecbb929246021 Cr-Commit-Position: refs/heads/master@{#338766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Peter Mayo
5 years, 5 months ago (2015-07-14 22:51:45 UTC) #1
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-14 22:56:47 UTC) #2
Peter Mayo
cc: phajdan.jr
5 years, 5 months ago (2015-07-14 23:11:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235233005/1
5 years, 5 months ago (2015-07-14 23:12:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 23:23:28 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 23:24:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d673f55c138f6b263375c096c43ecbb929246021
Cr-Commit-Position: refs/heads/master@{#338766}

Powered by Google App Engine
This is Rietveld 408576698