Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3603)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1235173002: Revert of Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index a116d2b52145cfc305c8b71a32db018779107b50..11190a7af90fdb88ae6e0a0979c5e7ee9100a050 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -13,16 +13,12 @@
#include "chrome/browser/extensions/signin/gaia_auth_extension_loader.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/signin_promo.h"
-#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_navigator.h"
-#include "chrome/browser/ui/browser_window.h"
#include "chrome/common/pref_names.h"
-#include "components/signin/core/common/profile_management_switches.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/base/url_util.h"
-#include "ui/aura/window.h"
InlineLoginHandler::InlineLoginHandler() {}
@@ -140,16 +136,5 @@
ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
chrome::Navigate(&params);
- signin_metrics::Source source = signin::GetSourceForPromoURL(main_frame_url);
- if (source == signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN ||
- source == signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT) {
- // Close the singleton avatar bubble to reveal the full tab UI.
- Browser* browser = chrome::FindAnyBrowser(
- profile, false,
- chrome::GetHostDesktopTypeForNativeView(web_contents->GetNativeView()));
- if (browser != nullptr)
- browser->window()->CloseAvatarBubbleFromAvatarButton();
- }
-
web_ui()->CallJavascriptFunction("inline.login.closeDialog");
}
« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698