DescriptionRevert of Chrome user menu shouldn't close if a tab steals focus (patchset #6 id:120001 of https://codereview.chromium.org/1136693002/)
Reason for revert:
This CL revealed issues 507686, 506158, 504772, 503938, 503932. Issue 504772 and 503938 can not be solved immediately, so we revert this cl to allow time to solve them or find alternative solutions.
Original issue's description:
> Chrome user menu shouldn't close if a tab steals focus.
>
> This CL is dedicated to fix above issue and achieve below behaviors:
> 1. User Menu does not close during sign-in flow: Things can't steal focus; the user menu stays open while you're typing / in the signin flow.
> 2. Sign-in confirmation is modal: The user menu is not closeable until the user interacts with the signin confirmation window. Sync should be delayed until the user interacts with the dialogue.
> 3. Blue information box: This shouldn't go away until the user explicitly interacts with it (not you, what's new, "x"). Doesn't affect modality/close-ability of the user menu.
>
> BUG=341196
>
> Committed: https://crrev.com/131615b8cfd0e9b3045f3384e06ec3d8eb4f272a
> Cr-Commit-Position: refs/heads/master@{#330789}
TBR=rogerta@chromium.org,msw@chromium.org,groby@chromium.org,jcivelli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=341196
Committed: https://crrev.com/15589a459c096ea61d0228b594e4d549e463e94d
Cr-Commit-Position: refs/heads/master@{#338927}
Patch Set 1 #
Created: 5 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 27 (11 generated)
|