Source/platform/fonts/shaping/CachingWordShaperTest.cpp - Issue 1235163007: Revert of Reland "Change fallback font collection in HarfBuzzShaper"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/CachingWordShaperTest.cpp

Issue 1235163007: Revert of Reland "Change fallback font collection in HarfBuzzShaper" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/shaping/CachingWordShaperTest.cpp

diff --git a/Source/platform/fonts/shaping/CachingWordShaperTest.cpp b/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

index 3f2ca52ab0826537b92e829355d437db4878c8e2..6285d799cfe8d21c99d1248010b5d5d32e5e9608 100644

--- a/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

+++ b/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

@@ -47,7 +47,7 @@

TextRun textRun(reinterpret_cast<const LChar*>("ABC DEF."), 8);

RefPtr<ShapeResult> result;

- CachingWordShapeIterator iterator(cache, textRun, font);

+ CachingWordShapeIterator iterator(cache, textRun, font, fallbackFonts);

ASSERT_TRUE(iterator.next(&result));

ASSERT_TRUE(result->runInfoForTesting(0, startIndex, numGlyphs, script));

EXPECT_EQ(0u, startIndex);

@@ -76,7 +76,7 @@

unsigned offset = 0;

RefPtr<ShapeResult> result;

- CachingWordShapeIterator iterator(cache, textRun, font);

+ CachingWordShapeIterator iterator(cache, textRun, font, fallbackFonts);

ASSERT_TRUE(iterator.next(&result));

ASSERT_TRUE(result->runInfoForTesting(0, startIndex, numGlyphs, script));

EXPECT_EQ(0u, offset + startIndex);

« no previous file with comments | « Source/platform/fonts/shaping/CachingWordShaper.cpp ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | no next file with comments »