Issue 1235163002: Remove unused PackBits methods and fix length checks

Issue 1235163002: Remove unused PackBits methods and fix length checks (Closed)

Created:
5 years, 5 months ago by hcm2

Modified:
5 years, 5 months ago

Reviewers:
hcm, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m44

Target Ref:
refs/heads/chrome/m44

Project:
skia

Visibility:
Public.

Remove unused PackBits methods and fix length checks Also a bit of general cleanup. BUG=chromium:486944 Review URL: https://codereview.chromium.org/1152163004 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/ee68678f0051e71efeb6affc3f4a071b7ac1c1bd

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -435 lines)			Patch
M	include/core/SkPackBits.h	View	2 chunks	+7 lines, -40 lines	0 comments	Download
M	src/core/SkPackBits.cpp	View	4 chunks	+25 lines, -327 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/PackBitsTest.cpp	View	3 chunks	+9 lines, -65 lines	0 comments	Download

Total messages: 7 (2 generated)

hcm

On 2015/07/14 13:44:40, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:mtklein@google.com, mailto:reed@google.com Mike or ...

5 years, 5 months ago (2015-07-14 13:46:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235163002/1

5 years, 5 months ago (2015-07-14 16:32:41 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 16:32:51 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee68678f0051e71efeb6affc3f4a071b7ac1c1bd