Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1235153009: Add more macros to .clang-format's MacroBlock{Begin,End} options. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
chromium-reviews, danakj, enne (OOO), jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more macros to .clang-format's MacroBlock{Begin,End} options. The number of macros is too damn high! BUG=373340 TBR=darin@chromium.org Committed: https://crrev.com/0941e7d8d20c708973a0742aa2579046c05c5be0 Cr-Commit-Position: refs/heads/master@{#339216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M .clang-format View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
Hopefully that's all of them...
5 years, 5 months ago (2015-07-16 21:58:39 UTC) #2
Nico
lgtm :-/
5 years, 5 months ago (2015-07-16 22:01:26 UTC) #3
danakj
Thanks for adding these.
5 years, 5 months ago (2015-07-16 22:02:36 UTC) #5
jsbell
lgtm2
5 years, 5 months ago (2015-07-16 22:03:26 UTC) #7
dcheng
TBRing darin@ on this one as well.
5 years, 5 months ago (2015-07-17 03:43:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235153009/1
5 years, 5 months ago (2015-07-17 03:43:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 03:51:57 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 03:53:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0941e7d8d20c708973a0742aa2579046c05c5be0
Cr-Commit-Position: refs/heads/master@{#339216}

Powered by Google App Engine
This is Rietveld 408576698