Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 1235113002: Remove map-copying for global objects. This was an old (broken) requirement that has been fixed for… (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove map-copying for global objects. This was an old (broken) requirement that has been fixed for a while. BUG= Committed: https://crrev.com/0cfb44e27d35334ffbb71410beecf16132d4e225 Cr-Commit-Position: refs/heads/master@{#29640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/objects.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-14 07:45:47 UTC) #2
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-14 09:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235113002/1
5 years, 5 months ago (2015-07-14 09:25:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 09:55:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 09:55:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfb44e27d35334ffbb71410beecf16132d4e225
Cr-Commit-Position: refs/heads/master@{#29640}

Powered by Google App Engine
This is Rietveld 408576698