Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235093002: Move sky_viewer into services/sky (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move sky_viewer into services/sky Moving sky_viewer into services/sky is more consistent with how all the other content handlers (e.g., dart, js, nacl, pdf, python) are organized. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0fbf75089168f11776ae6c13b5079bf015f6523d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2595 lines) Patch
M examples/sky_compositor_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/sky_compositor_app/sky_compositor_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + services/sky/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
A + services/sky/compositor/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/layer.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/sky/compositor/layer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + services/sky/compositor/layer_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/layer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/layer_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/sky/compositor/layer_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/sky/compositor/layer_host_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/layer_host_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/picture_serializer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/picture_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/rasterizer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/rasterizer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/rasterizer_bitmap.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/rasterizer_bitmap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/sky/compositor/rasterizer_ganesh.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/rasterizer_ganesh.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/sky/compositor/resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/resource_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/sky/compositor/surface_allocator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/surface_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/compositor/surface_holder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/surface_holder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/sky/compositor/texture_cache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/compositor/texture_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/content_handler_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/sky/content_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/sky/converters/basic_types.h View 1 chunk +1 line, -2 lines 0 comments Download
A + services/sky/converters/basic_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/converters/input_event_types.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sky/converters/input_event_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/dart_library_provider_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/sky/dart_library_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/document_view.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + services/sky/document_view.cc View 3 chunks +9 lines, -9 lines 0 comments Download
A + services/sky/internals.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/sky/internals.cc View 1 chunk +6 lines, -4 lines 0 comments Download
A + services/sky/runtime_flags.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/sky/runtime_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/sky/viewer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M sky/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/viewer/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/viewer/compositor/BUILD.gn View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/viewer/compositor/layer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/viewer/compositor/layer.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/viewer/compositor/layer_client.h View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/viewer/compositor/layer_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/viewer/compositor/layer_host.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/viewer/compositor/layer_host.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D sky/viewer/compositor/layer_host_client.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/viewer/compositor/layer_host_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/viewer/compositor/picture_serializer.h View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/viewer/compositor/picture_serializer.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/viewer/compositor/rasterizer.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/viewer/compositor/rasterizer.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/viewer/compositor/rasterizer_bitmap.h View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/viewer/compositor/rasterizer_bitmap.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/viewer/compositor/rasterizer_ganesh.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/viewer/compositor/rasterizer_ganesh.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/viewer/compositor/resource_manager.h View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/viewer/compositor/resource_manager.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/viewer/compositor/surface_allocator.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/viewer/compositor/surface_allocator.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/viewer/compositor/surface_holder.h View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/viewer/compositor/surface_holder.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/viewer/compositor/texture_cache.h View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/viewer/compositor/texture_cache.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/viewer/content_handler_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/viewer/content_handler_impl.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/viewer/converters/basic_types.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/viewer/converters/basic_types.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/viewer/converters/input_event_types.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/viewer/converters/input_event_types.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D sky/viewer/dart_library_provider_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/viewer/dart_library_provider_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/viewer/document_view.h View 1 chunk +0 lines, -138 lines 0 comments Download
D sky/viewer/document_view.cc View 1 chunk +0 lines, -321 lines 0 comments Download
D sky/viewer/internals.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/viewer/internals.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D sky/viewer/runtime_flags.h View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/viewer/runtime_flags.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/viewer/viewer.cc View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 05:16:26 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-14 06:03:23 UTC) #2
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
0fbf75089168f11776ae6c13b5079bf015f6523d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698