Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1235083004: Revert of d8 workers: make sure Shell::Quit is only called once (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5 id:80001 of https://codereview.chromium.org/1230403003/) Reason for revert: Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio Original issue's description: > d8 workers: make sure Shell::Quit is only called once > > When running with isolates, Quit can be called simultaneously by two threads. > If this happens, then both threads try to clean up the Workers, which could > crash. > > BUG=v8:4279 > R=jarin@chromium.org > R=machenbach@chromium.org > LOG=n > > Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c > Cr-Commit-Position: refs/heads/master@{#29654} TBR=jarin@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4279 Committed: https://crrev.com/6b2c6eb75678747afca59b4a78ace597e218145d Cr-Commit-Position: refs/heads/master@{#29656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M src/d8.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/d8.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
binji
Created Revert of d8 workers: make sure Shell::Quit is only called once
5 years, 5 months ago (2015-07-14 18:09:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083004/1
5 years, 5 months ago (2015-07-14 18:09:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-14 18:09:53 UTC) #4
adamk
lgtm
5 years, 5 months ago (2015-07-14 18:13:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083004/1
5 years, 5 months ago (2015-07-14 18:13:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 18:13:55 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b2c6eb75678747afca59b4a78ace597e218145d Cr-Commit-Position: refs/heads/master@{#29656}
5 years, 5 months ago (2015-07-14 18:14:11 UTC) #9
binji
5 years, 5 months ago (2015-07-14 19:20:22 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1224203004/ by binji@chromium.org.

The reason for reverting is: Looks like the failure is unrelated to my change
(still fails after the revert). See
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/856/....

Powered by Google App Engine
This is Rietveld 408576698