Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1235083002: WebWaitableEvent: update blink API implementations for html_viewer (Closed)

Created:
5 years, 5 months ago by Takashi Toyoshima
Modified:
5 years, 5 months ago
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebWaitableEvent: update blink API implementations for html_viewer This is html_viewer version of crrev.com/1225243002. To deprecate the old version of createWaitableEvent() with no arguments, implement two arguments version of createWaitableEvent() to support events require manual resets. BUG=507224 TEST=gn build of html_viewer with is_clang=true Committed: https://crrev.com/0acc9e557c40bf3318b7485586692ae31c880dae Cr-Commit-Position: refs/heads/master@{#338686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M components/html_viewer/blink_platform_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Takashi Toyoshima
sky: can you take a look?
5 years, 5 months ago (2015-07-14 05:00:18 UTC) #2
Takashi Toyoshima
Oops, sky is on vacation. jochen: Can you take a look this as a components ...
5 years, 5 months ago (2015-07-14 05:04:59 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-14 14:29:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083002/1
5 years, 5 months ago (2015-07-14 14:41:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 14:59:24 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 15:00:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0acc9e557c40bf3318b7485586692ae31c880dae
Cr-Commit-Position: refs/heads/master@{#338686}

Powered by Google App Engine
This is Rietveld 408576698