Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: sky/engine/tonic/dart_value.h

Issue 1235063005: Remove #include of RefPtr in dart_state.h (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/tonic/dart_state.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SKY_ENGINE_TONIC_DART_VALUE_H_ 5 #ifndef SKY_ENGINE_TONIC_DART_VALUE_H_
6 #define SKY_ENGINE_TONIC_DART_VALUE_H_ 6 #define SKY_ENGINE_TONIC_DART_VALUE_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "dart/runtime/include/dart_api.h" 9 #include "dart/runtime/include/dart_api.h"
10 #include "sky/engine/tonic/dart_persistent_value.h" 10 #include "sky/engine/tonic/dart_persistent_value.h"
11 #include "sky/engine/tonic/dart_state.h" 11 #include "sky/engine/tonic/dart_state.h"
12 #include "sky/engine/wtf/PassRefPtr.h"
13 #include "sky/engine/wtf/RefCounted.h"
12 #include "sky/engine/wtf/RefPtr.h" 14 #include "sky/engine/wtf/RefPtr.h"
13 15
14 namespace blink { 16 namespace blink {
15 17
16 // DartValue is a convience wrapper around DartPersistentValue that lets clients 18 // DartValue is a convience wrapper around DartPersistentValue that lets clients
17 // use RefPtr to keep track of the number of references to the underlying Dart 19 // use RefPtr to keep track of the number of references to the underlying Dart
18 // object. Be careful when retaining RefPtr<DartValue> in the heap because the 20 // object. Be careful when retaining RefPtr<DartValue> in the heap because the
19 // VM's garbage collector cannot break cycles that involve the C++ heap, which 21 // VM's garbage collector cannot break cycles that involve the C++ heap, which
20 // can lead to memory leaks. 22 // can lead to memory leaks.
21 class DartValue : public RefCounted<DartValue> { 23 class DartValue : public RefCounted<DartValue> {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 DartValue(DartState* dart_state, Dart_Handle value); 56 DartValue(DartState* dart_state, Dart_Handle value);
55 57
56 DartPersistentValue dart_value_; 58 DartPersistentValue dart_value_;
57 59
58 DISALLOW_COPY_AND_ASSIGN(DartValue); 60 DISALLOW_COPY_AND_ASSIGN(DartValue);
59 }; 61 };
60 62
61 } // namespace blink 63 } // namespace blink
62 64
63 #endif // SKY_ENGINE_TONIC_DART_VALUE_H_ 65 #endif // SKY_ENGINE_TONIC_DART_VALUE_H_
OLDNEW
« no previous file with comments | « sky/engine/tonic/dart_state.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698