Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * * Redistributions of source code must retain the above copyright 4 * * Redistributions of source code must retain the above copyright
5 * notice, this list of conditions and the following disclaimer. 5 * notice, this list of conditions and the following disclaimer.
6 * * Redistributions in binary form must reproduce the above 6 * * Redistributions in binary form must reproduce the above
7 * copyright notice, this list of conditions and the following disclaimer 7 * copyright notice, this list of conditions and the following disclaimer
8 * in the documentation and/or other materials provided with the 8 * in the documentation and/or other materials provided with the
9 * distribution. 9 * distribution.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 ASSERT_NOT_REACHED(); 87 ASSERT_NOT_REACHED();
88 return 0; 88 return 0;
89 } 89 }
90 90
91 template <CSSValueID IdForNone> 91 template <CSSValueID IdForNone>
92 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value) 92 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value)
93 { 93 {
94 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 94 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
95 if (primitiveValue->getValueID() == IdForNone) 95 if (primitiveValue->getValueID() == IdForNone)
96 return nullAtom; 96 return nullAtom;
97 return primitiveValue->getStringValue(); 97 return AtomicString(primitiveValue->getStringValue());
98 } 98 }
99 99
100 } // namespace WebCore 100 } // namespace WebCore
101 101
102 #endif 102 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698