components/favicon_base/fallback_icon_url_parser.cc - Issue 1234973004: Update SplitString calls in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/fallback_icon_url_parser.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon_base/fallback_icon_url_parser.cc

diff --git a/components/favicon_base/fallback_icon_url_parser.cc b/components/favicon_base/fallback_icon_url_parser.cc

index ba9f232176e92f58630d24bc9c50c8b7bb3ad961..8855695bfdfb88dd3211a847c6b3fbc1859c1f58 100644

--- a/components/favicon_base/fallback_icon_url_parser.cc

+++ b/components/favicon_base/fallback_icon_url_parser.cc

@@ -74,8 +74,8 @@ bool ParsedFallbackIconPath::ParseSpecs(

DCHECK(size);

DCHECK(style);

- std::vector<std::string> tokens;

- base::SplitStringDontTrim(specs_str, ',', &tokens);

+ std::vector<std::string> tokens = base::SplitString(

+ specs_str, ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

if (tokens.size() != 5) // Force "," for empty fields.

return false;