Issue 1234963002: Start an AddressBook example (to test text fields)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234963002: Start an AddressBook example (to test text fields) (Closed)

Created:
5 years, 5 months ago by eseidel

Modified:
5 years, 5 months ago

Reviewers:
abarth, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Start an AddressBook example (to test text fields) Also fixed a bug in tool_bar where not supplying a center caused right not to be on the right. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3f9bc784fa3eb3854d04c2eedcd18d3b660b74a3

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -15 lines)			Patch
A	sky/sdk/example/address_book/lib/main.dart	View	1 chunk	+101 lines, -0 lines	1 comment	Download
M	sky/sdk/lib/editing/input.dart	View	2 chunks	+16 lines, -6 lines	0 comments	Download
M	sky/sdk/lib/theme/theme_data.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/widgets/tool_bar.dart	View	1 chunk	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1234963002/diff/1/sky/sdk/example/address_book/lib/main.dart File sky/sdk/example/address_book/lib/main.dart (right): https://codereview.chromium.org/1234963002/diff/1/sky/sdk/example/address_book/lib/main.dart#newcode60 sky/sdk/example/address_book/lib/main.dart:60: new Field(icon:"social/person", placeholder:"Name"), s/:"/: "/

5 years, 5 months ago (2015-07-13 18:28:47 UTC) #2

eseidel

5 years, 5 months ago (2015-07-13 18:29:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3f9bc784fa3eb3854d04c2eedcd18d3b660b74a3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages