Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1234963002: Start an AddressBook example (to test text fields) (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Start an AddressBook example (to test text fields) Also fixed a bug in tool_bar where not supplying a center caused right not to be on the right. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3f9bc784fa3eb3854d04c2eedcd18d3b660b74a3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -15 lines) Patch
A sky/sdk/example/address_book/lib/main.dart View 1 chunk +101 lines, -0 lines 1 comment Download
M sky/sdk/lib/editing/input.dart View 2 chunks +16 lines, -6 lines 0 comments Download
M sky/sdk/lib/theme/theme_data.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1234963002/diff/1/sky/sdk/example/address_book/lib/main.dart File sky/sdk/example/address_book/lib/main.dart (right): https://codereview.chromium.org/1234963002/diff/1/sky/sdk/example/address_book/lib/main.dart#newcode60 sky/sdk/example/address_book/lib/main.dart:60: new Field(icon:"social/person", placeholder:"Name"), s/:"/: "/
5 years, 5 months ago (2015-07-13 18:28:47 UTC) #2
eseidel
5 years, 5 months ago (2015-07-13 18:29:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f9bc784fa3eb3854d04c2eedcd18d3b660b74a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698