Implement tear-off closure operator #

runtime/vm/resolver.cc

Index: runtime/vm/resolver.cc
diff --git a/runtime/vm/resolver.cc b/runtime/vm/resolver.cc
index 954f34076d069794050032ec65bd8c87f0e6a889..9d6972876468ae95f240f49e6af60904ace112ce 100644
--- a/runtime/vm/resolver.cc
+++ b/runtime/vm/resolver.cc
@@ -114,6 +114,32 @@ RawFunction* Resolver::ResolveDynamicAnyArgs(
   String& field_name = String::Handle();
   if (is_getter) {
     field_name ^= Field::NameFromGetter(function_name);
+
+    if (field_name.CharAt(0) == '#') {

[Ivan Posva, 2015/07/17 08:35:42]

Please add explanation here how we generate the closurization lookups. As far as
I understand it is done by creating an instance call "obj.get:#property()".
Additional explanation will help though.

[hausner, 2015/07/17 17:53:51]

Correct. I will add a comment. The # in the getter name signals that we want to
closurize a getter rather than calling it (which is what we do in the old
closurization semantics.)

+      String& property_name = String::Handle(String::SubString(field_name, 1));
+
+      ASSERT(!Field::IsGetterName(property_name));
+      String& method_name = String::Handle();
+      if (!Field::IsSetterName(property_name)) {

[Ivan Posva, 2015/07/17 08:35:42]

Please add comment why the property name needs to be adjusted for getters but
not for setters.

[hausner, 2015/07/17 17:53:51]

Will do.

+        method_name = Field::GetterName(property_name);
+      }
+
+      Function& function = Function::Handle();
+      while (!cls.IsNull()) {
+        function = cls.LookupDynamicFunction(property_name);
+        if (!function.IsNull()) {
+          return CreateMethodExtractor(function_name, function);
+        }
+        if (!method_name.IsNull()) {
+          function = cls.LookupDynamicFunction(method_name);
+          if (!function.IsNull()) {
+            return CreateMethodExtractor(function_name, function);
+          }
+        }
+        cls = cls.SuperClass();
+      }
+      return Function::null();
+    }
   }
 
   // Now look for an instance function whose name matches function_name