Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: Source/modules/webgl/WebGLExtension.h

Issue 1234883002: [Oilpan] Migrate classes under module/webgl onto oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Work for comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webgl/WebGLExtension.h
diff --git a/Source/modules/webgl/WebGLExtension.h b/Source/modules/webgl/WebGLExtension.h
index fb7c2f049ec47cd2708687a4335658768bc17742..cd67e8cdeb18912f08a53f005483bf18860c7411 100644
--- a/Source/modules/webgl/WebGLExtension.h
+++ b/Source/modules/webgl/WebGLExtension.h
@@ -31,15 +31,14 @@
#include "modules/webgl/WebGLExtensionName.h"
#include "modules/webgl/WebGLRenderingContextBase.h"
#include "platform/heap/Handle.h"
-#include "wtf/RefCounted.h"
namespace blink {
-class WebGLExtensionScopedContext : public NoBaseWillBeGarbageCollectedFinalized<WebGLExtensionScopedContext> {
+class WebGLExtensionScopedContext {
sof 2015/08/03 09:12:04 Add 'final' for maximum tidiness.
peria 2015/08/04 09:10:25 Done.
+ STACK_ALLOCATED();
WTF_MAKE_NONCOPYABLE(WebGLExtensionScopedContext);
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtensionScopedContext);
public:
- WebGLExtensionScopedContext(WebGLExtension*);
+ explicit WebGLExtensionScopedContext(WebGLExtension*);
virtual ~WebGLExtensionScopedContext();
sof 2015/08/03 09:12:04 No need for virtual, I think. You can arguably jus
peria 2015/08/04 09:10:25 Done.
bool isLost() { return !m_context; }
@@ -51,8 +50,7 @@ private:
RefPtrWillBeMember<WebGLRenderingContextBase> m_context;
};
-class WebGLExtension : public RefCountedWillBeGarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable {
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtension);
+class WebGLExtension : public GarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable {
public:
virtual ~WebGLExtension();
virtual WebGLExtensionName name() const = 0;

Powered by Google App Engine
This is Rietveld 408576698