Source/modules/webgl/WebGLContextGroup.cpp - Issue 1234883002: [Oilpan] Migrate classes under module/webgl onto oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGLContextGroup.cpp

Issue 1234883002: [Oilpan] Migrate classes under module/webgl onto oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Work for comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webgl/WebGLContextGroup.h ('K') | « Source/modules/webgl/WebGLContextGroup.h ('k') | Source/modules/webgl/WebGLContextObject.cpp » ('j') | Source/modules/webgl/WebGLExtension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webgl/WebGLContextGroup.cpp

diff --git a/Source/modules/webgl/WebGLContextGroup.cpp b/Source/modules/webgl/WebGLContextGroup.cpp

index b11b5f387a096a7e4301a86da93e8619953586dd..e56ba4f75b9d0f74c15888df278458e90c415bda 100644

--- a/Source/modules/webgl/WebGLContextGroup.cpp

+++ b/Source/modules/webgl/WebGLContextGroup.cpp

@@ -80,7 +80,7 @@ void WebGLContextGroup::addObject(WebGLSharedObject* object)

void WebGLContextGroup::detachAndRemoveAllObjects()

{

while (!m_groupObjects.isEmpty()) {

- HashSet<WebGLSharedObject*>::iterator it = m_groupObjects.begin();

+ PersistentHeapHashSet<WeakMember<WebGLSharedObject>>::iterator it = m_groupObjects.begin();

(*it)->detachContextGroup();

}