Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/modules/webgl/WebGLQuery.cpp

Issue 1234883002: [Oilpan] Migrate classes under module/webgl onto oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase & work for some comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "modules/webgl/WebGLQuery.h" 7 #include "modules/webgl/WebGLQuery.h"
8 8
9 #include "modules/webgl/WebGL2RenderingContextBase.h" 9 #include "modules/webgl/WebGL2RenderingContextBase.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 PassRefPtrWillBeRawPtr<WebGLQuery> WebGLQuery::create(WebGL2RenderingContextBase * ctx) 13 WebGLQuery* WebGLQuery::create(WebGL2RenderingContextBase* ctx)
14 { 14 {
15 return adoptRefWillBeNoop(new WebGLQuery(ctx)); 15 return new WebGLQuery(ctx);
16 } 16 }
17 17
18 WebGLQuery::~WebGLQuery() 18 WebGLQuery::~WebGLQuery()
19 { 19 {
20 // Always call detach here to ensure that platform object deletion 20 // Call detach here to ensure that platform object deletion happens.
21 // happens with Oilpan enabled. It keeps the code regular to do it
22 // with or without Oilpan enabled.
23 // 21 //
24 // See comment in WebGLBuffer's destructor for additional 22 // See comment in WebGLBuffer's destructor for additional
25 // information on why this is done for WebGLSharedObject-derived 23 // information on why this is done for WebGLSharedObject-derived
26 // objects. 24 // objects.
27 detachAndDeleteObject(); 25 detachAndDeleteObject();
28 } 26 }
29 27
30 WebGLQuery::WebGLQuery(WebGL2RenderingContextBase* ctx) 28 WebGLQuery::WebGLQuery(WebGL2RenderingContextBase* ctx)
31 : WebGLSharedPlatform3DObject(ctx) 29 : WebGLSharedPlatform3DObject(ctx)
32 , m_target(0) 30 , m_target(0)
33 { 31 {
34 setObject(ctx->webContext()->createQueryEXT()); 32 setObject(ctx->webContext()->createQueryEXT());
35 } 33 }
36 34
37 void WebGLQuery::setTarget(GLenum target) 35 void WebGLQuery::setTarget(GLenum target)
38 { 36 {
39 ASSERT(object()); 37 ASSERT(object());
40 ASSERT(!m_target); 38 ASSERT(!m_target);
41 m_target = target; 39 m_target = target;
42 } 40 }
43 41
44 void WebGLQuery::deleteObjectImpl(WebGraphicsContext3D* context3d) 42 void WebGLQuery::deleteObjectImpl(WebGraphicsContext3D* context3d)
45 { 43 {
46 context3d->deleteQueryEXT(m_object); 44 context3d->deleteQueryEXT(m_object);
47 m_object = 0; 45 m_object = 0;
48 } 46 }
49 47
50 } // namespace blink 48 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698