[Oilpan] Migrate classes under module/webgl onto oilpan heap

Source/modules/webgl/WebGLBuffer.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 13 matching lines @@
  */
 
 #include "config.h"
 
 #include "modules/webgl/WebGLBuffer.h"
 
 #include "modules/webgl/WebGLRenderingContextBase.h"
 
 namespace blink {
 
-PassRefPtrWillBeRawPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)
+WebGLBuffer* WebGLBuffer::create(WebGLRenderingContextBase* ctx)
 {
-    return adoptRefWillBeNoop(new WebGLBuffer(ctx));
+    return new WebGLBuffer(ctx);
 }
 
 WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)
     : WebGLSharedPlatform3DObject(ctx)
     , m_initialTarget(0)
 {
     setObject(ctx->webContext()->createBuffer());
 }
 
 WebGLBuffer::~WebGLBuffer()
 {
-    // Delete the buffer's platform object. This object will have been
-    // detached from the WebGLContextGroup if the group object was
-    // finalized first. With Oilpan not enabled, it always will be,
-    // but with Oilpan enabled, the WebGLBuffer might end up being
-    // finalized first. In which case detachment is needed to ensure
-    // that the platform object is indeed deleted.
-    //
-    // To keep the code regular, the trivial detach()ment is always
-    // performed.
+    // Delete the buffer's platform object.
+    // This object will have been detached from the WebGLContextGroup
+    // if the group object was finalized first, but the WebGLBuffer
+    // might end up being finalized first.
+    // In which case detachment is needed to ensure that the platform
+    // object is indeed deleted.

[haraken, 2015/08/05 04:12:19]

Slightly clearer:

There is no guarantee about the order between WebGLContextGroup's destruction
and WebGLBuffer's destruction. So we cannot rely on the WebGLContextGroup's
destructor for deleting the platform objects of the WebGLBuffers. Hence we
delete the platform objects in the WebGLBuffer's destructor.

Also it would be better to move this comment to
WebGLObject::detachAndDeleteObject().

- Have the comment in WebGLObject::detachAndDeleteObject().
- In each destructor of an object that inherits from WebGLObject, add "see the
comment in WebGLObject::detachAndDeleteObject()".

[peria, 2015/08/06 05:46:59]

Done.

     detachAndDeleteObject();
 }
 
 void WebGLBuffer::deleteObjectImpl(WebGraphicsContext3D* context3d)
 {
     context3d->deleteBuffer(m_object);
     m_object = 0;
 }
 
 void WebGLBuffer::setInitialTarget(GLenum target)
 {
     // WebGL restricts the ability to bind buffers to multiple targets based on
     // it's initial bind point.
     ASSERT(!m_initialTarget);
     m_initialTarget = target;
 }
 
 } // namespace blink