[Oilpan] Migrate classes under module/webgl onto oilpan heap

Source/modules/webgl/WebGL2RenderingContext.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebGL2RenderingContext_h
 #define WebGL2RenderingContext_h
 
 #include "core/html/canvas/CanvasRenderingContextFactory.h"
 #include "modules/webgl/WebGL2RenderingContextBase.h"
 
@@ skipping 20 matching lines @@
     CanvasRenderingContext::ContextType contextType() const override { return CanvasRenderingContext::ContextWebgl2; }
     unsigned version() const override { return 2; }
     String contextName() const override { return "WebGL2RenderingContext"; }
     void registerContextExtensions() override;
 
     DECLARE_VIRTUAL_TRACE();
 
 protected:
     WebGL2RenderingContext(HTMLCanvasElement* passedCanvas, PassOwnPtr<WebGraphicsContext3D>, const WebGLContextAttributes& requestedAttributes);
 
-    RefPtrWillBeMember<CHROMIUMSubscribeUniform> m_chromiumSubscribeUniform;
-    RefPtrWillBeMember<EXTTextureFilterAnisotropic> m_extTextureFilterAnisotropic;
-    RefPtrWillBeMember<OESTextureFloatLinear> m_oesTextureFloatLinear;
-    RefPtrWillBeMember<WebGLCompressedTextureATC> m_webglCompressedTextureATC;
-    RefPtrWillBeMember<WebGLCompressedTextureETC1> m_webglCompressedTextureETC1;
-    RefPtrWillBeMember<WebGLCompressedTexturePVRTC> m_webglCompressedTexturePVRTC;
-    RefPtrWillBeMember<WebGLCompressedTextureS3TC> m_webglCompressedTextureS3TC;
-    RefPtrWillBeMember<WebGLDebugRendererInfo> m_webglDebugRendererInfo;
-    RefPtrWillBeMember<WebGLDebugShaders> m_webglDebugShaders;
-    RefPtrWillBeMember<WebGLLoseContext> m_webglLoseContext;
+    PersistentWillBeMember<CHROMIUMSubscribeUniform> m_chromiumSubscribeUniform;
+    PersistentWillBeMember<EXTTextureFilterAnisotropic> m_extTextureFilterAnisotropic;
+    PersistentWillBeMember<OESTextureFloatLinear> m_oesTextureFloatLinear;
+    PersistentWillBeMember<WebGLCompressedTextureATC> m_webglCompressedTextureATC;
+    PersistentWillBeMember<WebGLCompressedTextureETC1> m_webglCompressedTextureETC1;
+    PersistentWillBeMember<WebGLCompressedTexturePVRTC> m_webglCompressedTexturePVRTC;
+    PersistentWillBeMember<WebGLCompressedTextureS3TC> m_webglCompressedTextureS3TC;
+    PersistentWillBeMember<WebGLDebugRendererInfo> m_webglDebugRendererInfo;
+    PersistentWillBeMember<WebGLDebugShaders> m_webglDebugShaders;
+    PersistentWillBeMember<WebGLLoseContext> m_webglLoseContext;

[haraken, 2015/08/04 00:06:52]

These persistent handles can be removed if you move CanvasRenderingContext to
the oilpan heap at the same time. Is there any reason that makes it hard to move
CanvasRenderingContext to the oilpan heap?

Either way, I think we can keep the current CL (already huge) as is and move
CanvasRenderingContext in a follow-up CL.

[Ken Russell (switch to Gerrit), 2015/08/04 00:34:10]

Understanding that this is the reason for the persistent handles, let's
definitely leave these as persistent handles rather than weak members. Moving
CanvasRenderingContext into the Oilpan heap at the same time as the
WebGLRenderingContext sounds like too much to do in a single CL. I'm sure junov@
will agree.

[peria, 2015/08/04 09:10:25]

Acknowledged.
http://crbug.com/516607

 };
 
 DEFINE_TYPE_CASTS(WebGL2RenderingContext, CanvasRenderingContext, context,
     context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) == 2,
     context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) == 2);
 
 } // namespace blink
 
 #endif