Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2011 Apple Inc. All rights reserved. | 2 * Copyright (C) 2011 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 64 | 64 |
| 65 void detachAndRemoveAllObjects(); | 65 void detachAndRemoveAllObjects(); |
| 66 | 66 |
| 67 // FIXME: Oilpan: this object is not on the heap, but keeps bare | 67 // FIXME: Oilpan: this object is not on the heap, but keeps bare |
| 68 // pointers to garbage collected objects in the two hash sets | 68 // pointers to garbage collected objects in the two hash sets |
| 69 // below. The objects are responsible for managing their | 69 // below. The objects are responsible for managing their |
| 70 // registration with WebGLContextGroup, and vice versa, the | 70 // registration with WebGLContextGroup, and vice versa, the |
| 71 // WebGLContextGroup takes care of detaching the group objects if | 71 // WebGLContextGroup takes care of detaching the group objects if |
| 72 // the set of WebGLRenderingContextBase contexts becomes empty. | 72 // the set of WebGLRenderingContextBase contexts becomes empty. |
| 73 HashSet<WebGLRenderingContextBase*> m_contexts; | 73 HashSet<WebGLRenderingContextBase*> m_contexts; |
| 74 HashSet<WebGLSharedObject*> m_groupObjects; | 74 PersistentHeapHashSet<Member<WebGLSharedObject>> m_groupObjects; |
|
Ken Russell (switch to Gerrit)
2015/08/01 00:11:56
I think we should file a bug about removing these
peria
2015/08/03 09:00:35
I agree to remove them, but I think it is not good
| |
| 75 }; | 75 }; |
| 76 | 76 |
| 77 } // namespace blink | 77 } // namespace blink |
| 78 | 78 |
| 79 #endif // WebGLContextGroup_h | 79 #endif // WebGLContextGroup_h |
| OLD | NEW |