Issue 1234873005: Rename right & bottom crop edges to width & height.

Issue 1234873005: Rename right & bottom crop edges to width & height. (Closed)

Created:
5 years, 5 months ago by Stephen White

Modified:
5 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Now that the SkImageFilter::CropRect crop edges refer to width & height, name them appropriately. BUG=240827 Committed: https://skia.googlesource.com/skia/+/ed7cf273226ca5818a9d58b0f9183d665bb1ff58

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	include/core/SkImageFilter.h	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (4 generated)

reed1

Will likely need a manual rebase, but LGTM Next, lets follow-through and eliminate these flags ...

5 years, 5 months ago (2015-07-16 21:03:52 UTC) #2

reed1

lgtm -- you'll need to land that guard in skia/config/SkUserConfig.h first, so this CL doesn't ...

5 years, 5 months ago (2015-07-16 21:15:30 UTC) #4

Stephen White

On 2015/07/16 21:15:30, reed1 wrote: > lgtm -- you'll need to land that guard in ...

5 years, 5 months ago (2015-07-16 22:02:07 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234873005/20001

5 years, 5 months ago (2015-07-16 22:11:40 UTC) #9

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 22:19:14 UTC) #10

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ed7cf273226ca5818a9d58b0f9183d665bb1ff58