sky/sdk/lib/widgets/fixed_height_scrollable.dart - Issue 1234863004: Remove redundant setState() calls around scroll behaviour updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/fixed_height_scrollable.dart

Issue 1234863004: Remove redundant setState() calls around scroll behaviour updates. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/widgets/fixed_height_scrollable.dart

diff --git a/sky/sdk/lib/widgets/fixed_height_scrollable.dart b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

index e35cfb92b09a43bc28510151f6038a52fbe99f3a..06ce7d35ae2171492a073d37a9e2b6d6d843323a 100644

--- a/sky/sdk/lib/widgets/fixed_height_scrollable.dart

+++ b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

@@ -85,6 +85,9 @@ abstract class FixedHeightScrollable extends Scrollable {

List<Widget> items = buildItems(itemShowIndex, itemShowCount);

assert(items.every((item) => item.key != null));

+ // TODO(ianh): Refactor this so that it does the building in the

+ // same frame as the size observing, similar to BlockViewport, but

+ // keeping the fixed-height optimisations.

return new SizeObserver(

callback: _handleSizeChanged,

child: new Viewport(

« no previous file with comments | « no previous file | sky/sdk/lib/widgets/scrollable_viewport.dart » ('j') | sky/sdk/lib/widgets/variable_height_scrollable.dart » ('J')