Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1234833003: Debugger: use debug break slots to break at function exit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix for arm Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2808 matching lines...) Expand 10 before | Expand all | Expand 10 after
2819 CheckBuffer(); 2819 CheckBuffer();
2820 *reinterpret_cast<uint32_t*>(pc_) = 2820 *reinterpret_cast<uint32_t*>(pc_) =
2821 reinterpret_cast<uint32_t>(stub->instruction_start()); 2821 reinterpret_cast<uint32_t>(stub->instruction_start());
2822 pc_ += sizeof(uint32_t); 2822 pc_ += sizeof(uint32_t);
2823 } 2823 }
2824 2824
2825 2825
2826 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 2826 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
2827 // We do not try to reuse pool constants. 2827 // We do not try to reuse pool constants.
2828 RelocInfo rinfo(pc_, rmode, data, NULL); 2828 RelocInfo rinfo(pc_, rmode, data, NULL);
2829 if (rmode >= RelocInfo::JS_RETURN && 2829 if (rmode >= RelocInfo::COMMENT &&
2830 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL) { 2830 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL) {
2831 // Adjust code for new modes. 2831 // Adjust code for new modes.
2832 DCHECK(RelocInfo::IsDebugBreakSlot(rmode) 2832 DCHECK(RelocInfo::IsDebugBreakSlot(rmode)
2833 || RelocInfo::IsJSReturn(rmode)
2834 || RelocInfo::IsComment(rmode) 2833 || RelocInfo::IsComment(rmode)
2835 || RelocInfo::IsPosition(rmode)); 2834 || RelocInfo::IsPosition(rmode));
2836 // These modes do not need an entry in the constant pool. 2835 // These modes do not need an entry in the constant pool.
2837 } 2836 }
2838 if (!RelocInfo::IsNone(rinfo.rmode())) { 2837 if (!RelocInfo::IsNone(rinfo.rmode())) {
2839 // Don't record external references unless the heap will be serialized. 2838 // Don't record external references unless the heap will be serialized.
2840 if (rmode == RelocInfo::EXTERNAL_REFERENCE && 2839 if (rmode == RelocInfo::EXTERNAL_REFERENCE &&
2841 !serializer_enabled() && !emit_debug_code()) { 2840 !serializer_enabled() && !emit_debug_code()) {
2842 return; 2841 return;
2843 } 2842 }
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
3095 if (patched) { 3094 if (patched) {
3096 CpuFeatures::FlushICache(pc + 2, sizeof(Address)); 3095 CpuFeatures::FlushICache(pc + 2, sizeof(Address));
3097 } 3096 }
3098 } 3097 }
3099 3098
3100 3099
3101 } // namespace internal 3100 } // namespace internal
3102 } // namespace v8 3101 } // namespace v8
3103 3102
3104 #endif // V8_TARGET_ARCH_MIPS 3103 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698